Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: paper configs #156

Merged
merged 23 commits into from
Jun 5, 2023
Merged

feat: paper configs #156

merged 23 commits into from
Jun 5, 2023

Conversation

clement-bonnet
Copy link
Collaborator

@clement-bonnet clement-bonnet commented Jun 2, 2023 •
edited
Loading

  • up BinPack version to v2 with configs to make it faster
  • up Connector version to v2 with the RandomWalkGenerator that guarantees an optimal prop_connections of 1
  • add step_count to the observation of MMST
  • fix Tetris doc
  • fix Knapsack configs (50 items instead of 20) -> I do not up the version since there has been no releases that includes this bug
  • set time_limit of Tetris to 400 instead of 4000
  • fix Tetris termination and termination reward
  • improve MMST speed by parallelizing some operations
  • add all environments to training configs
  • update all training configs to match the paper
  • add step_count to MMST network
  • improve Tetris network

@clement-bonnet clement-bonnet added the enhancement New feature or request label Jun 2, 2023
@clement-bonnet clement-bonnet self-assigned this Jun 2, 2023
@clement-bonnet clement-bonnet marked this pull request as ready for review June 4, 2023 20:51
ulricharmel
ulricharmel previously approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@ulricharmel ulricharmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mmst changes looks good to me.

@clement-bonnet clement-bonnet requested a review from djbyrne June 5, 2023 09:50
dluo96
dluo96 reviewed Jun 5, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
dluo96
dluo96 reviewed Jun 5, 2023
View reviewed changes
README.md Show resolved Hide resolved
dluo96
dluo96 reviewed Jun 5, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
dluo96
dluo96 previously approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@dluo96 dluo96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clement-bonnet @dluo96
Update README.md
fada7c9 
Co-authored-by: Daniel <57721552+dluo96@users.noreply.github.com>
@clement-bonnet clement-bonnet merged commit c866204 into instadeepai:main Jun 5, 2023
@clement-bonnet clement-bonnet deleted the final-configs branch June 5, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TristanKalloniatis TristanKalloniatis TristanKalloniatis left review comments

@ulricharmel ulricharmel ulricharmel left review comments

@djbyrne djbyrne djbyrne left review comments

@dluo96 dluo96 dluo96 approved these changes

Assignees

@clement-bonnet clement-bonnet

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clement-bonnet @djbyrne @ulricharmel @TristanKalloniatis @dluo96