Feature: Add Readme for setting up a new environment #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DriesSmit
requested review from
arnupretorius and
KaleabTessera
as code owners
arnupretorius
previously approved these changes
Aug 19, 2021
|
Note: checks failing due to AutoRom, which will be fixed in this PR: #300 |
|
Looks great @DriesSmit !! Thanks for adding this. Maybe add a pointer to this in the main readme here (https://github.com/instadeepai/Mava#supported-environments). Something like "For details on how to add your own environment, see (here)[link]". |
KaleabTessera
previously approved these changes
Aug 19, 2021
DriesSmit
dismissed stale reviews from KaleabTessera and arnupretorius
via
659f74e
Great idea @KaleabTessera 👍 I added a reference in the main text. |
arnupretorius
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a Readme to guide users on how to take a new environment and make it compatible with Mava.
Why?
.
How?
Add a Readme to the wrappers folder inside Mava.
Extra