update Dockerfile for SMAC installation #286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
[Describe what was changed and reference relevant issue.]
From Pull Request: #284
This modification related to the issue when install Docker for SMAC: #282
I tried to install Docker to both Python 3.6 and Python 3.7 and figure out that pysc2 needed as well as uninstall enum34 is needed before pip install oxwhiri/smac github repo to prevent enum-Python 3.6 error. Note that there are suggestion for update enum instead of uninstall but this will not work
Why?
[Describe why the change was made.]
To be able to install Docker on Python 3.6, 3.7 correctly
How?
[Describe how the change was made i.e. describe technically what the change does.]
Shown below
Extra
[Any extra information.]
Also, I suggested to update the main Docker repo to up-to-date with the develop one since it does not have uninstall enum and it cause problem in install Docker.
I know that develop is a default git clone but many user might still try to use main branch instead