Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include prepare scripts for npm-modules & react-components #436

Closed
hanford opened this issue Mar 12, 2018 · 2 comments
Closed

include prepare scripts for npm-modules & react-components #436

hanford opened this issue Mar 12, 2018 · 2 comments
Labels
enhancement

Comments

@hanford
Copy link
Contributor

hanford commented Mar 12, 2018

This issue is a:

  • Feature request

It's pretty common to utilize npm's lifecycle commands .. In my case, I'd love react-components and npm-modules I bootstrap with nwb to include a prepare script that simply invokes npm run build ensuring that whenever I publish a new version, my new code will be rebuilt.

Is this something that has been considered? I'd love to open a PR if it's welcome.

Cheers!
@insin
Copy link
Owner

insin commented Mar 15, 2018

@hanford Yes, a PR would be most welcome 😸

@hanford hanford mentioned this issue Mar 16, 2018
Merged
@hanford
Copy link
Contributor Author

hanford commented Mar 16, 2018

@insin wasn't sure if I was supposed to base off of the next branch or master, I can redo the PR on next if master was incorrect.

Cheers! 🍻

@insin insin closed this as completed Mar 17, 2018
insin added a commit that referenced this issue Mar 17, 2018
@insin
Update CHANGES for #436
1aba4b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@insin @hanford