-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Builtins] Optimize 'Typed' via 'INLINE' pragmas #4264
Conversation
/benchmark |
df42f6b
to
9804959
Compare
Comparing benchmark results of 'b778f9abb' (base) and 'df42f6ba9' (PR)
|
9804959
to
838f4dc
Compare
/benchmark |
Comparing benchmark results of 'b778f9abb' (base) and '838f4dcde' (PR)
|
/benchmark |
Comparing benchmark results of 'b778f9abb' (base) and '838f4dcde' (PR)
|
/benchmark |
Comparing benchmark results of 'b778f9abb' (base) and 'a3d042783' (PR)
|
eabadb9
to
250e69b
Compare
/benchmark |
Comparing benchmark results of 'b778f9abb' (base) and '250e69b84' (PR)
|
0005a98
to
57e8588
Compare
/benchmark |
57e8588
to
f2721f0
Compare
/benchmark |
Comparing benchmark results of 'b778f9abb' (base) and '57e8588c2' (PR)
|
f2721f0
to
69ea808
Compare
/benchmark |
69ea808
to
4ee1dc5
Compare
/benchmark |
Comparing benchmark results of 'b778f9abb' (base) and 'f2721f05d' (PR)
|
/benchmark |
172e27d
to
56ed505
Compare
/benchmark |
Comparing benchmark results of 'b778f9abb' (base) and 'abc363fcd' (PR)
|
/benchmark |
Comparing benchmark results of 'b778f9abb' (base) and '939df8b41' (PR)
|
/benchmark |
Comparing benchmark results of 'b778f9abb' (base) and '14d14f416' (PR)
|
/benchmark |
Comparing benchmark results of 'b778f9abb' (base) and '7c76ff8dc' (PR)
|
/benchmark |
Comparing benchmark results of 'b778f9abb' (base) and '7c76ff8dc' (PR)
|
This reverts commit 7c76ff8.
/benchmark |
Comparing benchmark results of 'b778f9abb' (base) and '42f54ef29' (PR)
|
This reverts commit 42f54ef.
/benchmark |
Comparing benchmark results of 'b778f9abb' (base) and '726356c56' (PR)
|
This (bad results) is when I add So what does Anyhow, I've chosen the version that was reliably fast previously (the one with Merging. |
It might affect how the unfoldings are optimized (which isn't always easily visible in the Core). Which would then affect how good the code is when they get inlined? That's my best guess. |
…e default universe (IntersectMBO#4264)
I looked at Core and found some opportunities for optimization. The Core now looks better, but let's see what benchmarks say. If things are not slower, I'll add some docs and merge that.