Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pool of resources to maintain locks for #370

Merged
merged 7 commits into from
Jan 18, 2023

Conversation

fsuhrau
Copy link
Contributor

@fsuhrau fsuhrau commented Dec 28, 2022

defines a pool of resources which can be locked by the bot
can be used to share resources in the team like servers, devices, books, ...

@fsuhrau fsuhrau force-pushed the feature/resource_pool branch from aad6f8e to dc35d90 Compare December 28, 2022 15:56
- provide mock for SendBlockMessageToUser
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #370 (fb2cda3) into master (c029b6d) will decrease coverage by 5.75%.
The diff coverage is 6.89%.

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   82.22%   76.47%   -5.76%     
==========================================
  Files         114      118       +4     
  Lines        5008     5406     +398     
==========================================
+ Hits         4118     4134      +16     
- Misses        799     1181     +382     
  Partials       91       91              
Impacted Files Coverage Δ
bot/command.go 100.00% <ø> (ø)
bot/config/config.go 100.00% <ø> (ø)
command/pool/pool.go 0.00% <0.00%> (ø)
command/pool/pool_commands.go 0.00% <0.00%> (ø)
client/slack.go 69.46% <9.09%> (-6.75%) ⬇️
command/pool/commands.go 46.15% <46.15%> (ø)
bot/listener.go 51.47% <62.50%> (+1.47%) ⬆️
bot/config/pool.go 100.00% <100.00%> (ø)
bot/fallback.go 100.00% <100.00%> (ø)
command/add_button.go 100.00% <100.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

command/pool/commands.go Outdated Show resolved Hide resolved
- linter warnings
- make its possible to have GetInteractionButton in a row ( requires an unique action id )
- fix addres for ResourceLock
- send block message if more then one market is locked
@brainexe brainexe merged commit a15ae46 into innogames:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants