Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gateway error returns #1990

Closed
wants to merge 11 commits into from
Closed

Fix gateway error returns #1990

wants to merge 11 commits into from

Conversation

jpwilliams
Copy link
Member

Description

Fixes error handling when an AI gateway fails.

  • f2937ea OnStepFinished() lifecycles now run after response handling. Before Gateways #1962, the response from an SDK contained everything we would need to build appropriate traces. Following Gateways #1962, gateway requests are made during handling of opcodes, meaning we must wait for them to be fully handled before writing any spans
  • 1dac722 Sets a more compliant userland error when the gateway fails, making sure it's in the proper format and parseable by the UI too
  • 2808d84 Use the same new userland error to save to state, making sure what we see in the UI lines up with what the SDK sees

Type of change (choose one)

  • Chore (refactors, upgrades, etc.)
  • Bug fix (non-breaking change that fixes an issue)
  • Security fix (non-breaking change that fixes a potential vulnerability)
  • Docs
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

  • I've linked any associated issues to this PR.
  • I've tested my own changes.

Related

Check our Pull Request Guidelines

@jpwilliams jpwilliams added the bug Something isn't working label Nov 25, 2024
@jpwilliams jpwilliams self-assigned this Nov 25, 2024
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 0:54am

@jpwilliams jpwilliams marked this pull request as ready for review November 25, 2024 14:24
@vercel vercel bot requested a deployment to Preview January 9, 2025 12:03 Abandoned
@jpwilliams
Copy link
Member Author

Superseded by #2074.

@jpwilliams jpwilliams closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants