Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry integration tests twice before failing the test #2892

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Retry integration tests twice before failing the test #2892

merged 1 commit into from
Nov 28, 2022

Conversation

romac
Copy link
Member

@romac romac commented Nov 28, 2022

Closes: #XXX

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested a review from soareschen November 28, 2022 18:14
@romac romac marked this pull request as ready for review November 28, 2022 18:14
@romac romac merged commit 7813dc9 into master Nov 28, 2022
@romac romac deleted the romac/retry-flaky-tests branch November 28, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soareschen soareschen soareschen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romac @soareschen