Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how the client uses logging #434

Merged
merged 5 commits into from
May 6, 2022
Merged

docs: how the client uses logging #434

merged 5 commits into from
May 6, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 29, 2022

Related to #364 (comment)

Proposed Changes

Added description how the client used log and debug information:

image

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.16%. Comparing base (215eb88) to head (b0b126c).
Report is 139 commits behind head on master.

Files with missing lines Patch % Lines
influxdb_client/configuration.py 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   88.17%   88.16%   -0.02%     
==========================================
  Files          38       38              
  Lines        3213     3210       -3     
==========================================
- Hits         2833     2830       -3     
  Misses        380      380              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar marked this pull request as ready for review April 29, 2022 09:17
@bednar bednar requested a review from rhajek April 29, 2022 09:17
Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit 60438b2 into master May 6, 2022
@bednar bednar deleted the logging branch May 6, 2022 08:53
@bednar bednar added this to the 1.29.0 milestone May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants