Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added possibility to specify certificate file path to verify the peer #158

Merged
merged 3 commits into from
Sep 24, 2020
Merged

feat: added possibility to specify certificate file path to verify the peer #158

merged 3 commits into from
Sep 24, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Sep 24, 2020 •
edited
Loading

Closes #157

Proposed Changes

  • added possibility to specify certificate file path to verify the peer

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar added the enhancement New feature or request label Sep 24, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020 •
edited
Loading

Codecov Report

Merging #158 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   89.03%   89.11%   +0.08%     
==========================================
  Files          25       25              
  Lines        1897     1902       +5     
==========================================
+ Hits         1689     1695       +6     
+ Misses        208      207       -1
Impacted Files Coverage Δ
influxdb_client/client/influxdb_client.py 98.43% <100.00%> (+0.06%) ⬆️
influxdb_client/rest.py 81.20% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc0fe1...3658400. Read the comment docs.

@bednar bednar mentioned this pull request Sep 24, 2020
Closed
@bednar bednar marked this pull request as ready for review September 24, 2020 09:17
@bednar bednar requested a review from rhajek September 24, 2020 09:17
@rhajek rhajek merged commit 8c7d312 into master Sep 24, 2020
@bednar bednar added this to the 1.11.0 milestone Sep 24, 2020
@bednar bednar deleted the feat/cert-configuration branch September 29, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhajek rhajek rhajek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Possibility to pass custom ssl cert
3 participants
@bednar @codecov-commenter @rhajek