[Merged by Bors] - refactor(smartengine): reuse code for transforms except agg #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, why do we need to bump version for such change? 👀 |
|
Just need patch version |
|
@sehz PTAL |
sehz
reviewed
Apr 6, 2023
sehz
requested changes
Apr 6, 2023
sehz
requested changes
Apr 6, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2023
All transforms except agg shares the same code, so this PR unifies them into one shared implementation. By the way, in `smartmodule-derive`, all these transforms except agg shares the same implementation via `generate_transform`, so I think it also makes sense to reuse code in smartengine.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All transforms except agg shares the same code, so this PR unifies them into one shared implementation. By the way, in
smartmodule-derive, all these transforms except agg shares the same implementation viagenerate_transform, so I think it also makes sense to reuse code in smartengine.