[Merged by Bors] - feat: Metric endpoint #2737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 22, 2022
Expose new Metric endpoint for SPU using UnixSocket. In response to UnixSocket request, metric would be returned as simple json:
```
nc -U /tmp/fluvio-spu.sock
{
"records_read": 6,
"records_write": 0,
"bytes_read": 508,
"bytes_written": 0,
"smartmodule": {
"bytes_in": 166,
"records_out": 0,
"invocation_count": 6
}
```
This implementation uses a simple atomic counters Instead of OpenTelemetry counters which are hard to reason with it. This is aggegrate counter for records and bytes. Detail counters will be added in the subsequent PR
In the Kubernetes, we get using exec:
```
kubectl exec fluvio-spg-main-0 -- apk add socat
kubectl exec fluvio-spg-main-0 -- socat UNIX-CONNECT:/tmp/fluvio-spu.sock -
```
SPU automatically remove existing socks file if it already exists.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
davidbeesley
pushed a commit
to davidbeesley/fluvio
that referenced
this pull request
Oct 31, 2022
Expose new Metric endpoint for SPU using UnixSocket. In response to UnixSocket request, metric would be returned as simple json:
```
nc -U /tmp/fluvio-spu.sock
{
"records_read": 6,
"records_write": 0,
"bytes_read": 508,
"bytes_written": 0,
"smartmodule": {
"bytes_in": 166,
"records_out": 0,
"invocation_count": 6
}
```
This implementation uses a simple atomic counters Instead of OpenTelemetry counters which are hard to reason with it. This is aggegrate counter for records and bytes. Detail counters will be added in the subsequent PR
In the Kubernetes, we get using exec:
```
kubectl exec fluvio-spg-main-0 -- apk add socat
kubectl exec fluvio-spg-main-0 -- socat UNIX-CONNECT:/tmp/fluvio-spu.sock -
```
SPU automatically remove existing socks file if it already exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose new Metric endpoint for SPU using UnixSocket. In response to UnixSocket request, metric would be returned as simple json:
This implementation uses a simple atomic counters Instead of OpenTelemetry counters which are hard to reason with it. This is aggegrate counter for records and bytes. Detail counters will be added in the subsequent PR
In the Kubernetes, we get using exec:
SPU automatically remove existing socks file if it already exists.