[Merged by Bors] - feat: add record counters to spu #2731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nacardin
force-pushed
the
storage_metrics
branch
from
6958969 to
504b905
Compare
sehz
requested changes
Oct 21, 2022
crates/fluvio-spu/Cargo.toml
Outdated
| @@ -40,7 +40,9 @@ thiserror = "1" | |||
| once_cell = "1.5" | |||
| sysinfo = "0.26.0" | |||
| nix = { version = "0.25"} | |||
|
|
|||
| async-global-executor = { version = "2.3.0", features = ["tokio"] } | |||
There was a problem hiding this comment.
removed exporting from this pr
| &self.topic_metrics.metrics.context, | ||
| value, | ||
| &[ | ||
| opentelemetry::KeyValue::new("direction", "read"), |
There was a problem hiding this comment.
Can some of these be made into const? This is not show stopper.
There was a problem hiding this comment.
Not sure if that would be good in this case, lets defer discussion to later
| let (header, produce_request) = request.get_header_request(); | ||
| trace!("Handling ProduceRequest: {:#?}", produce_request); | ||
|
|
||
| let mut topic_results = Vec::with_capacity(produce_request.topics.len()); | ||
| for topic_request in produce_request.topics.into_iter() { | ||
| let topic_result = handle_produce_topic(&ctx, topic_request).await; | ||
| let topic_result = handle_produce_topic(&ctx, topic_request, &metrics).await; |
There was a problem hiding this comment.
Instead of passing as argument, we can add to context. not show stopper
nacardin
force-pushed
the
storage_metrics
branch
from
f6a5cb1 to
73fa980
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
Co-authored-by: Nick Cardin <nick@cardin.email>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
davidbeesley
pushed a commit
to davidbeesley/fluvio
that referenced
this pull request
Oct 31, 2022
Co-authored-by: Nick Cardin <nick@cardin.email>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.