-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - fix: recover from invalid segments #2909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migrate storage api to use anyhow
renaming low level replica api
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 30, 2022
resolves #2509. Recover from invalid logs due to incorrect batch encoding. It does this by setting the log size to the last correct batches. Tested with data from corrupted segments. - More clean and simplification of the Log validator. - Migrated more API to use anyhow
Canceled. |
bors r- |
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 30, 2022
resolves #2509. Recover from invalid logs due to incorrect batch encoding. It does this by setting the log size to the last correct batches. Tested with data from corrupted segments. - More clean and simplification of the Log validator. - Migrated more API to use anyhow
Build failed: |
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 30, 2022
resolves #2509. Recover from invalid logs due to incorrect batch encoding. It does this by setting the log size to the last correct batches. Tested with data from corrupted segments. - More clean and simplification of the Log validator. - Migrated more API to use anyhow
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
fix: recover from invalid segments
[Merged by Bors] - fix: recover from invalid segments
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2509.
Recover from invalid logs due to incorrect batch encoding. It does this by setting the log size to the last correct batches.
Tested with data from corrupted segments.