Fix argument list too long #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
============================================
+ Coverage 73.07% 73.09% +0.01%
+ Complexity 1224 1217 -7
============================================
Files 182 181 -1
Lines 3997 4033 +36
Branches 298 300 +2
============================================
+ Hits 2921 2948 +27
- Misses 980 990 +10
+ Partials 96 95 -1
Continue to review full report at Codecov.
|
sarod
force-pushed
the
fix-argument-list-too-long
branch
from
7bfaa2a to
1ee80aa
Compare
move environement to dedicated package Reorganize environement related tests
sarod
force-pushed
the
fix-argument-list-too-long
branch
2 times, most recently
from
20c57f3 to
1787aa7
Compare
sarod
force-pushed
the
fix-argument-list-too-long
branch
from
1787aa7 to
6d37712
Compare
gtoison
added a commit
to erroraway/infinitest
that referenced
this pull request
Aug 14, 2022
mockito-inline relies on instrumentation to mock static methods, this does not seem to be possible when the classloader is overridden because it does not implement the required methods Pull request infinitest#260 was introduced to solve the problem when the classpath is too big to fit in the shell environment. Since Java 9 it is possible to use argument file expanded by the java process, use this native feature instead of a custom classloader Introduced ClasspathArgumentBuilder to the pre Java 9 case (use standard arguments) and post Java 9 (use an argument file)
gtoison
added a commit
that referenced
this pull request
Sep 24, 2022
fix: replacing the system classloader prevents instrumentation mockito-inline relies on instrumentation to mock static methods, this does not seem to be possible when the classloader is overridden because it does not implement the required methods Pull request #260 was introduced to solve the problem when the classpath is too big to fit in the shell environment. Since Java 9 it is possible to use argument file expanded by the java process, use this native feature instead of a custom classloader Introduced ClasspathArgumentBuilder to the pre Java 9 case (use standard arguments) and post Java 9 (use an argument file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161 #161