[1.x] Restore command + click behavior on Inertia links in React #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #1910 (d53b2b3), we switched to passing `event.nativeEvent` to `shouldIntercept` in an attempt to consistently always pass native browser events to this framework-agnostic helper. This actually introduced a bug though, because `currentTarget` is _different_ on React's synthetic event vs. the underlying native event. The correct value for `currentTarget` lives on the synthetic event. Since we are no longer relying on `event.which` (and this is the only property we used to be concerned with that was not included on the React synthetic event), we'll simply move back to passing the React synthetic event to `shouldIntercept`.
derrickreimer
changed the title
derrickreimer
commented
Dec 12, 2024
| event: Pick< | ||
| MouseEvent, | ||
| 'altKey' | 'ctrlKey' | 'defaultPrevented' | 'target' | 'currentTarget' | 'metaKey' | 'shiftKey' | 'button' | ||
| >, |
There was a problem hiding this comment.
There might be a more elegant way to do this? I didn't want to introduce a dependency on React type definitions in the core package (to make this a union type), so figured the next best thing was to narrow this down to accommodate both native and synthetic event shapes.
I confirmed that TypeScript will fail if this is type is just a MouseEvent, since React.MouseEvent contains some different stuff.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1910 (d53b2b3), we switched to passing
event.nativeEventtoshouldInterceptin an attempt to consistently always pass native browser events to this framework-agnostic helper. This actually introduced a bug though, becausecurrentTargetis different on React's synthetic event vs. the underlying native event. The correct value forcurrentTargetlives on the synthetic event.Since we are no longer relying on
event.which(and this is the only property we used to be concerned with that was not included on the React synthetic event), we'll simply move back to passing the React synthetic event toshouldIntercept.