Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(vue): Allowing stronger type support of useForm objects. #1413

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Feat(vue): Allowing stronger type support of useForm objects. #1413

merged 3 commits into from
Feb 14, 2023

Conversation

Nesuarg
Copy link
Contributor

@Nesuarg Nesuarg commented Jan 26, 2023 •
edited by thecrypticace
Loading

By exporting InertiaForm type, we can have stronger typing of useForm.

in my case I would like to do:
type TwoWheeler = InertiaForm<MyBike> | InertiaForm<MyScooter>;

This allow me to exclude objects like "MyCar"

@Nesuarg Nesuarg mentioned this pull request Jan 26, 2023
Closed
@jessarcher jessarcher self-requested a review February 2, 2023 00:06
@BR0kEN-
Copy link

BR0kEN- commented Feb 7, 2023

Fixes #1402

@timoransky
Copy link

timoransky commented Feb 12, 2023 •
edited
Loading

I would also love to see this merged since it kinda broke all our types during the upgrade to v1.0 😞

@jessarcher jessarcher self-assigned this Feb 13, 2023
@jessarcher jessarcher merged commit ec11808 into inertiajs:master Feb 14, 2023
@jessarcher
Copy link
Member

Thanks! I've made the same change to the Vue 2 adapter as well to help keep them consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessarcher jessarcher Awaiting requested review from jessarcher

Assignees

@jessarcher jessarcher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nesuarg @BR0kEN- @timoransky @jessarcher