CI over Windows #207
Merged
CI over Windows #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes for shorter roundtrip while doing the ol' pull-request-push-crash-fix-rinse-and-repeat
Nice opportunity to check if the caching mechanism was well introduced
| @@ -374,7 +374,12 @@ find_file_and_check_src(_Config) -> | |||
| [] = elvis_file:find_files(Dirs, "doesnt_exist.erl"), | |||
| [File] = elvis_file:find_files(Dirs, "small.erl"), | |||
|
|
|||
| {<<"-module(small).\n">>, _} = elvis_file:src(File), | |||
| {<<"-module(small).", LineBreak/binary>>, _} = elvis_file:src(File), | |||
elbrujohalcon
approved these changes
Sep 7, 2021
g-andrade
reviewed
Sep 7, 2021
| = case os:type() of | ||
| {unix, _} -> <<"\n">>; | ||
| {win32, _} -> <<"\r\n">> | ||
| end, |
There was a problem hiding this comment.
^ This approach will not work as expected if someone clones the elvis_core repo with auto-conversion from \n to \n\r\ disabled, but that should be a very rare occurrence (and people developing Erlang on Windows are already rare enough to start with)
There was a problem hiding this comment.
Yeah, I thought about that edge case, but was mostly interested in the CI. If it breaks for somebody we'll deal with it then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HopefullyCloses #180.