[Fix #166] Extend default configuration #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to use lists:filter/2 instead of lists:dropwhile/2
harenson
changed the title
harenson
changed the title
harenson
changed the title
| @@ -10,8 +10,16 @@ TEST_DEPS = meck | |||
|
|
|||
| dep_meck = git https://github.com/eproxus/meck 0.8.3 | |||
|
|
|||
| SHELL_DEPS = sync goldrush | |||
There was a problem hiding this comment.
instead of adding goldrush as a dep, use lager not from hex but from github
| % If any default rule is in UserRules it means the user | ||
| % wants to override the rule. | ||
| fun({FileName, RuleName}) -> | ||
| true /= is_rule_override(FileName, RuleName, UserRules); |
There was a problem hiding this comment.
instead of true /= |predicate|, please use not |predicate| or just change is_rule_override to should_use_default and return the opposite value from it.
| }, | ||
| #{dirs => ["."], | ||
| filter => "Makefile", | ||
| rules => [{elvis_project, no_deps_master_erlang_mk, #{ignore => []}}, | ||
| {elvis_project, protocol_for_deps_erlang_mk, #{ignore => []}}] | ||
| rule_group => makefiles |
| % remains just the rules the user wants to override. | ||
| lists:filter( | ||
| fun({_FileName, _RuleName, OverrideOptions}) -> | ||
| disable /= OverrideOptions; |
There was a problem hiding this comment.
I usually use =/= because it's an exact comparison. In this case it doesn't matter though since we are comparing an atom to a value and the match can only be exact.
jfacorro
added a commit
that referenced
this pull request
Jan 11, 2016
…iguration [Fix #166] Extend default configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.