[Closes #261] Options for max module line length #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -394,14 +394,27 @@ dont_repeat_yourself(Config, Target, RuleConfig) -> | |||
| max_module_length(Config, Target, RuleConfig) -> | |||
| MaxLength = maps:get(max_length, RuleConfig, 500), | |||
| IgnoreModules = maps:get(ignore, RuleConfig, []), | |||
| CountComments = maps:get(count_comments, RuleConfig, false), | |||
There was a problem hiding this comment.
can we make it work the other way around? like ignore_comments instead of count_comments?
There was a problem hiding this comment.
I tried that first (actually with skip_*) but it is a lot more confusing for the user when setting a value for the options. count_* is an affirmation while ignore_* is a negation. What should ignore_comments do? Ignore them in the sense of counting them so they add up to the line count or ignore them in the sense of not counting them?
elbrujohalcon
pushed a commit
that referenced
this pull request
Aug 31, 2015
[Closes #261] Options for max module line length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#261