Allows NaturalOrdering for Comparable type hierarchies #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elucash what do you think? |
|
@elucash anything else I should do to get this PR merged? |
|
sorry for the very long delay. It was hard for me to understand this PR from the first look, seems like it's only allowing proper bounds for collections. Thank you for the PR, merging |
|
@elucash thanks again! When can we expect a new minor/patch release? Would you consider doing a small one this week with these small patches? |
|
version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to write some of our code to use the
@Value.NaturalOrderannotation for comparable wrapped types and it failed. A simple fix was to use an upper bound wildcard in the generated code. Also added a testcase with an example.