Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: svelte5 #54

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feat: svelte5 #54

merged 1 commit into from
Nov 12, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Nov 12, 2024

Upgrade to svelte5 and runes.

@jrasm91 jrasm91 requested a review from alextran1502 November 12, 2024 13:52
Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, are you planning to replace those svelte/legacy in a separate PR?

Can you test the purchase flow for both product types to make sure there is no issue?

Copy link

📖 Preview of buy.immich.app deployed to pr-54.preview.buy.immich.app

Copy link

📖 Preview of my.immich.app deployed to pr-54.preview.my.immich.app

@jrasm91
Copy link
Contributor Author

jrasm91 commented Nov 12, 2024

Looks good, are you planning to replace those svelte/legacy in a separate PR?

Can you test the purchase flow for both product types to make sure there is no issue?

I am not personally planning on doing anything else at the moment. I'm sure we can replace the legacy stuff in the future though. I did do an end to end test with both the client and server license key and well as my.immich.app flow as well. Everything seems to still work.

@jrasm91 jrasm91 merged commit f9bfb65 into main Nov 12, 2024
4 checks passed
@jrasm91 jrasm91 deleted the feat/svelte5 branch November 12, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants