[Feature] Start all Immich metrics with word "immich_". #8191
Replies: 4 comments 6 replies
-
|
I think setting a global prefix is not supported by the library we use: pragmaticivan/nestjs-otel#265 @mertalev thoughts? |
Beta Was this translation helpful? Give feedback.
-
|
Only the io metrics can easily use a prefix since they're custom. We'd have to monkeypatch things to force the prefix in other cases. All the metrics have immich as the service name, so that might also help with discovery. |
Beta Was this translation helpful? Give feedback.
-
Yep, this was initially aimed as more of a development / debugging tool. But I also want to add these kinds of metrics as well as job metrics. |
Beta Was this translation helpful? Give feedback.
-
|
I've made an upstream PR to allow prefixing the API metrics here. I'm not sure if we should change the repo metrics now, or wait for that change so they're consistent. |
Beta Was this translation helpful? Give feedback.
-
|
As a workaround, here's part of my - job_name: immich_microservices
static_configs:
- targets: ["immich-microservices:8081"]
metric_relabel_configs:
- source_labels: [ __name__ ]
target_label: __name__
regex: '(.*)'
action: replace
replacement: immich_${1}Note that I don't think you need to add the same relabeling config to the
|
Beta Was this translation helpful? Give feedback.
-
|
That's a really good find! We should add that to the official config. A small tweak can be to change the regex to this: |
Beta Was this translation helpful? Give feedback.
-
|
When I tried your regex suggestion above |
Beta Was this translation helpful? Give feedback.
-
|
Hmm, Go's regex engine apparently doesn't support lookarounds. |
Beta Was this translation helpful? Give feedback.
-
|
I don't have a good setup to test it myself, but would it work to just do this? - job_name: immich_microservices
static_configs:
- targets: ["immich-microservices:8081"]
metric_relabel_configs:
- source_labels: [ __name__ ]
target_label: __name__
regex: '(immich_)?(.*)'
action: replace
replacement: immich_${2} |
Beta Was this translation helpful? Give feedback.
-
|
The last regex you shared works well 👍 |
Beta Was this translation helpful? Give feedback.
-
The feature
Finding Immich metrics is a chore as none of the metrics contain the word "immich" which makes finding and discovery of metrics annoying. I don't want to have to curl both the endpoints to figure out metric names instead of going to Prometheus Web interface and type "immich" and they all start showing up as you type.
Looks like the initial round of metrics are developer focused. Please consider adding metrics that can be used for a typical dashboards... number of: images, movies, albums, people, objects, faces not associated to person, etc.
Platform
Beta Was this translation helpful? Give feedback.
All reactions