Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix algorithm to compute XRRay.matrix #728

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Conversation

bialpio
Copy link
Contributor

@bialpio bialpio commented Jun 21, 2019

Fixes for current algorithm to obtain XRRay.matrix:

  • Dot product does not result in an angle between 2 vectors but is used as such.
  • Magnitude of cross product of 2 vectors can be 0 but rotation can still be necessary.

Additionally, it seems that there used to be some trailing whitespace that got removed by my editor.

Fixes for current algorithm to obtain XRRay.matrix:
- Dot product does not result in an angle between 2 vectors
  but is used as such.
- Magnitude of cross product of 2 vectors can be 0
  but rotation can still be necessary.
@bialpio bialpio changed the title Fix algorithm to XRRay.matrix Fix algorithm to compute XRRay.matrix Jun 21, 2019
@toji
Copy link
Member

toji commented Jun 21, 2019

LGTM! Thanks for the whitespace cleanup too. :)

@toji toji merged commit 0e096ed into immersive-web:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants