Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move racy parts of requestSession() to the main thread #706

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Move racy parts of requestSession() to the main thread #706

merged 2 commits into from
Jun 17, 2019

Conversation

Manishearth
Copy link
Contributor

@Manishearth Manishearth mentioned this pull request Jun 14, 2019
Closed
toji
toji requested changes Jun 17, 2019
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending the addition of some load-bearing whitespace.

index.bs Outdated
1. If |immersive| is <code>true</code>:
1. If the algorithm is not [=triggered by user activation=], [=reject=] |promise| with a "{{SecurityError}}" {{DOMException}} and return |promise|.
1. If [=pending immersive session=] is <code>true</code> or [=active immersive session=] is not <code>null</code>, [=reject=] |promise| with an "{{InvalidStateError}}" {{DOMException}} and return |promise|.
1. Set [=pending immersive session=] to be <code>true</code>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line appears to need a bit of additional indentation to logically fall under the If immersive is true: condition.

@Manishearth
Copy link
Contributor Author

Fixed!

@toji
Copy link
Member

toji commented Jun 17, 2019

Thanks you!

@toji toji merged commit 329d642 into immersive-web:master Jun 17, 2019
@toji toji added this to the June 2019 milestone Jun 17, 2019
@AdaRoseCannon AdaRoseCannon added the ed:spec Include in newsletter, spec change label Jun 17, 2019
@Manishearth Manishearth deleted the requestsession-racy branch August 13, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toji toji toji requested changes

Assignees
No one assigned
Labels
ed:spec Include in newsletter, spec change
Projects
None yet
Milestone
June 2019
Development

Successfully merging this pull request may close these issues.

requestSession() should set "pending immersive session" synchronously
3 participants
@Manishearth @toji @AdaRoseCannon