Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XRLayer base type. #688

Merged
merged 2 commits into from
Jun 10, 2019
Merged

Remove XRLayer base type. #688

merged 2 commits into from
Jun 10, 2019

Conversation

toji
Copy link
Member

@toji toji commented Jun 10, 2019

/fixes #268

Also changed baseLayer to only accept an XRWebGLLayer. This can be
extended in the future in a few ways:

  • Re-introduce XRLayer and change baseLayer to take one.
  • Update baseLayer to accept a union of layer types.
  • Leave baseLayer as WebGL-only and enforce that new layer types must
    use whatever layer array mechanism is introduced.

Also changed `baseLayer` to only accept an `XRWebGLLayer`. This can be
extended in the future in a few ways:

 - Re-introduce XRLayer and change `baseLayer` to take one.
 - Update `baseLayer` to accept a union of layer types.
 - Leave `baseLayer` as WebGL-only and enforce that new layer types must
   use whatever layer array mechanism is introduced.
@toji toji added this to the June 2019 milestone Jun 10, 2019
Copy link
Member

@NellWaliczek NellWaliczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just have a few nits.

explainer.md Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link
Member

@NellWaliczek NellWaliczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@toji toji merged commit 4a8df20 into master Jun 10, 2019
@toji toji deleted the remove-xrlayer branch June 10, 2019 20:34
@AdaRoseCannon AdaRoseCannon added ed:explainer Include in newsletter, explainer change ed:spec Include in newsletter, spec change labels Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ed:explainer Include in newsletter, explainer change ed:spec Include in newsletter, spec change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is XRLayer useful?
4 participants