Indicate when compositing is using depth values #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a concern brought up by @kearwood during the discussion of #523. He pointed out that it would be useful for some apps to know if the compositor actually was using the depth values in the case where `ignoreDepthValues` was not set to `true` at layer creation time, because that would allow some applications to skip an unnecessary explicit depth write step that they otherwise would be happy to do if they knew it would contribute to the final frame. Following the pattern set by other WebGL-style attributes like `antialias`, this PR indicates that the layer attribute should communicate whether or not depth values are actually being ignored by the compositor, rather than simply echo the boolean passed in at layer creation time.
NellWaliczek
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a concern brought up by @kearwood during the discussion
of #523. He pointed out that it would be useful for some apps to know
if the compositor actually was using the depth values in the case where
ignoreDepthValueswas not set totrueat layer creation time,because that would allow some applications to skip an unnecessary
explicit depth write step that they otherwise would be happy to do if
they knew it would contribute to the final frame.
Following the pattern set by other WebGL-style attributes like
antialias, this PR indicates that the layer attribute shouldcommunicate whether or not depth values are actually being ignored by
the compositor, rather than simply echo the boolean passed in at layer
creation time.