Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup frame and viewport caching to be explicit #1093

Merged
merged 5 commits into from
Jul 1, 2020

Conversation

Manishearth
Copy link
Contributor

@Manishearth Manishearth commented Jun 30, 2020

Fixes #1090

Also fixes #1092 by adding a timestamp comparison.


Preview | Diff

@Manishearth Manishearth requested a review from toji June 30, 2020 22:35
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

index.bs Outdated
1. Set |activeState| to |newState|.
1. If |oldLayer| is not equal to |activeState|'s {{XRRenderState/baseLayer}}, [=update the viewports=] for |session|.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but it doesn't account for the possibility that the existing baseLayer's dimensions change. That's an edge case, admittedly, and I don't think you need to block this PR because of it, just something to consider.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants