Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention correct input frame semantics on XRInputSource/frame #1053

Merged
merged 1 commit into from
May 29, 2020
Merged

Mention correct input frame semantics on XRInputSource/frame #1053

merged 1 commit into from
May 29, 2020

Conversation

Manishearth
Copy link
Contributor

@Manishearth Manishearth commented May 20, 2020 •
edited by pr-preview bot
Loading

getViewerPose() step 3 will raise an InvalidStateError with input frames, so the line about views arrays being empty is meaningless since you can't create XRViewerPoses anyway.

fixes #1054

Preview | Diff

@Manishearth Manishearth requested a review from toji May 20, 2020 17:48
toji
toji approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Manishearth Manishearth merged commit efa3f25 into immersive-web:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toji toji toji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event frame pose?
2 participants
@Manishearth @toji