Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requestReferenceSpace() should talk more about when you can reject the request #564

Closed
Manishearth opened this issue Mar 18, 2019 · 6 comments · Fixed by #651
Closed

requestReferenceSpace() should talk more about when you can reject the request #564

Manishearth opened this issue Mar 18, 2019 · 6 comments · Fixed by #651
Assignees
@toji
Labels
fixed by pending PR A PR that is in review will resolve this issue.
Milestone
May 2019

Comments

@Manishearth
Copy link
Contributor

There's a list of situations where requestReferenceSpace() can fail listed in the explainer, this should be part of the spec.
@Manishearth
Copy link
Contributor Author

(A lot of that document needs to be moved to the spec, really. I guess this is part of the plan?)

@NellWaliczek
Copy link
Member

Yep, good catch. We'll aim to get this fixed before we snap the next Working Draft, but there's a chance it will get pushed to a subsequent snap.

@NellWaliczek NellWaliczek added this to the Next Working Draft milestone Mar 25, 2019
@Manishearth
Copy link
Contributor Author

I might try adding it myself if I get time. (I wanted to be sure we wanted this in the spec in the first place)

@cwilso cwilso mentioned this issue Apr 29, 2019
Closed
@NellWaliczek
Copy link
Member

@Manishearth did you want to pick this one up?

@Manishearth
Copy link
Contributor Author

Sure!

Manishearth added a commit to Manishearth/webxr that referenced this issue May 16, 2019
@Manishearth
Explicitly spec out when requestReferenceSpace() can reject queries
62215b7 
fixes immersive-web#564
@Manishearth Manishearth mentioned this issue May 16, 2019
Merged
@Manishearth
Copy link
Contributor Author

#651

@toji toji added the fixed by pending PR A PR that is in review will resolve this issue. label May 16, 2019
Manishearth added a commit to Manishearth/webxr that referenced this issue May 16, 2019
@Manishearth
Explicitly spec out when requestReferenceSpace() can reject queries
8cb9998 
fixes immersive-web#564
Manishearth added a commit to Manishearth/webxr that referenced this issue May 16, 2019
@Manishearth
Explicitly spec out when requestReferenceSpace() can reject queries
e6a5019 
fixes immersive-web#564
@toji toji closed this as completed in #651 May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toji toji

Labels
fixed by pending PR A PR that is in review will resolve this issue.
Projects
None yet
Milestone
May 2019
Development

Successfully merging a pull request may close this issue.

Explicitly spec out when requestReferenceSpace() can reject queries Manishearth/webxr
3 participants
@toji @Manishearth @NellWaliczek