Resolved issue #1323 Two-Step View pattern #3106
Conversation
|
|
@iluwatar may you review this PR ? |
|
Dear @iluwatar may you check my PR? |
|
This is a gentle follow up. |
| @@ -0,0 +1,79 @@ | |||
| # Book Data Processing and Presentation | |||
There was a problem hiding this comment.
README.md has a very specific format that needs to be implemented by all the pattern examples. See here: https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute
| <properties> | ||
| <maven.compiler.source>17</maven.compiler.source> | ||
| <maven.compiler.target>17</maven.compiler.target> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| </properties> |
There was a problem hiding this comment.
Comes already from parent pom.xml
| <artifactId>junit</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| </dependencies> |
There was a problem hiding this comment.
Add maven-assembly-plugin to allow executing the jar from the command line. See the other patterns for examples.
|
|
||
| import java.util.logging.Logger; | ||
|
|
||
| /** Main class. */ |
There was a problem hiding this comment.
Here, above the App class, explain the pattern and describe how this example implements it.
| // Convert raw book data into a structured format | ||
| BookStore preparedData = DataPreparation.prepareBook(book); | ||
|
|
||
| String htmlOutput = Presentation.presentBook(preparedData); |
|
Thank you for your review. I am in the midst of final exams right now. May I work on it next week? |
Sure, no problem. Good luck with the exams 😄 |
created a two-step view design pattern for more details check the read-me file
close issue #1323