Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add key bindings for changing subtitle font size #4824

Closed
low-batt opened this issue Feb 16, 2024 · 3 comments · Fixed by #4852
Closed

Add key bindings for changing subtitle font size #4824

low-batt opened this issue Feb 16, 2024 · 3 comments · Fixed by #4852
Assignees
@svobs
Labels
feature: ui/ux progress: fixed/implemented type: enhancement

Comments

@low-batt
Copy link
Contributor

What you want IINA to do:
Provide key bindings for changing subtitle font size.

What IINA does currently:
IINA does not provide any bindings for this in the IINA Default key bindings. The mpv Default key bindings contains the following entries:

Key Command
⇧g add sub-scale +0.1
⇧f add sub-scale -0.1

These keys have not been assigned in the IINA Default key bindings. IINA should consider adding bindings that match the mpv Default key bindings.

Why you think this should be added:
This was requested in this comment on issue #4457.

Examples of other projects that have something similar:
mpv
@low-batt low-batt mentioned this issue Feb 16, 2024
Open
@svobs
Copy link
Contributor

svobs commented Feb 17, 2024

Seems like the IINA Default config should strive to be a superset of the mpv Default config?

@low-batt
Copy link
Contributor Author

Maybe. For now just address this specific case as if we keep the change simple the reviewers should approve it for the upcoming bug fix release.

Lets see what the reviewers say about adding more mpv bindings. If they think that is a good idea then such a change can go into the feature release.

We are getting closer to having all the PRs ready for the bug fix release, but are behind on merging.

@svobs svobs mentioned this issue Mar 18, 2024
Merged
2 tasks
@low-batt low-batt linked a pull request Mar 18, 2024 that will close this issue
Add G and F key bindings to IINA Default config (closes #4824) #4852
Merged
2 tasks
@low-batt
Copy link
Contributor Author

low-batt commented Jun 9, 2024

This was added in IINA 1.3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svobs svobs

Labels
feature: ui/ux progress: fixed/implemented type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add G and F key bindings to IINA Default config (closes #4824) svobs/iina-advance
2 participants
@svobs @low-batt