Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Chinese localization in preferences is incomplete #4644

Closed
DevLiuSir opened this issue Oct 11, 2023 · 11 comments · Fixed by #4690
Closed

The Chinese localization in preferences is incomplete #4644

DevLiuSir opened this issue Oct 11, 2023 · 11 comments · Fixed by #4690
Assignees
@low-batt
Labels
bug priority: high progress: fixed/implemented type: localization

Comments

@DevLiuSir
Copy link

After multiple version iterations. This problem persists.

iShot_2023-10-11_08 58 32
@low-batt
Copy link
Contributor

Reproduced for me.

I checked several other languages and localization was missing for them as well.

There were some recent regressions in localization, but this is not one of those. I checked IINA 1.2.0 and it also exhibited the problem.

Other developers handle localization, I will mention this problem to them.

@svobs
Copy link
Contributor

svobs commented Oct 11, 2023

Please see also Subtitles (menu) > Find Online Subtitles from... as mentioned in #4588.

@DevLiuSir
Copy link
Author

Please see also Subtitles (menu) > Find Online Subtitles from... as mentioned in #4588.

OK。thank you.

@low-batt low-batt self-assigned this Nov 14, 2023
low-batt added a commit that referenced this issue Nov 14, 2023
@low-batt
Fix missing Chinese localization in UI settings, #4644
a0e00b0 
This commit will add the missing English translation for the setting
"Always show float on top status in the title bar" to enable the
ability to add Chinese and other translations in Crowdin.
@low-batt low-batt mentioned this issue Nov 14, 2023
Merged
2 tasks
@low-batt low-batt linked a pull request Nov 14, 2023 that will close this issue
Fix missing Chinese localization in UI settings, #4644 #4690
Merged
2 tasks
svobs pushed a commit to svobs/iina-advance that referenced this issue Dec 4, 2023
@low-batt @svobs
Fix missing Chinese localization in UI settings, iina#4644
616ae07 
This commit will add the missing English translation for the setting
"Always show float on top status in the title bar" to enable the
ability to add Chinese and other translations in Crowdin.
lhc70000 pushed a commit that referenced this issue Dec 25, 2023
@low-batt
Fix missing Chinese localization in UI settings, #4644 (#4690)
1c9bb23 
This commit will add the missing English translation for the setting
"Always show float on top status in the title bar" to enable the
ability to add Chinese and other translations in Crowdin.
@low-batt
Copy link
Contributor

The fix for this issue has been merged into the IINA develop branch. GitHub automatically closed the linked issue in reaction to the merge. I am reopening this issue until the fix is available in an official release of IINA so that users intending to report this problem can easily locate this existing report. Once the fix for this issue has been included in an official release this issue will be closed.

@low-batt low-batt reopened this Dec 25, 2023
@uiryuu
Copy link
Member

uiryuu commented Jan 2, 2024

The corresponding string has been translated on Crowdin, so this issue should be fixed in the next release.

@DevLiuSir
Copy link
Author

1.3.4 still doesn't fix the missing localization.
As shown in the picture:

iShot_2024-01-04_20 11 01

@uiryuu
Copy link
Member

uiryuu commented Jan 5, 2024

@DevLiuSir Please wait for the next release. The new translation didn't catch the 1.3.4 release

@DevLiuSir
Copy link
Author

Please wait for the next release. The new translation didn't catch the 1.3.4 release

OK。thanks you！

@uiryuu
Copy link
Member

uiryuu commented Jan 7, 2024

Ref: #4740

@DevLiuSir
Copy link
Author

1.3.5 has fixed this issue!

@low-batt
Copy link
Contributor

low-batt commented Jun 6, 2024

@DevLiuSir Thanks for all your help with this problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@low-batt low-batt

Labels
bug priority: high progress: fixed/implemented type: localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing Chinese localization in UI settings, #4644 iina/iina
4 participants
@svobs @DevLiuSir @uiryuu @low-batt