Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playback History window: no confirmation when Backspace key used #4255

Closed
svobs opened this issue Mar 10, 2023 · 2 comments · Fixed by #4256
Closed

Playback History window: no confirmation when Backspace key used #4255

svobs opened this issue Mar 10, 2023 · 2 comments · Fixed by #4256
Assignees
@svobs
Labels
bug priority: high progress: fixed/implemented

Comments

@svobs
Copy link
Contributor

svobs commented Mar 10, 2023

System and IINA version:

  • macOS 13.1
  • IINA 1.3.1 Build 133

Expected behavior:

Because right-click on an entry in this window puts up a confirmation dialog before deleting, one would expect the same if using the Backspace key.

Actual behavior:
No confirmation. Item(s) immediately deleted.

Also, using Ctrl+Backspace, or Shift+Backspace, Option+Backspace (i.e. any modifier other than Command) also deletes the entry, when they probably shouldn't. Also one would expect the Delete key to work also, but it does not.

How often does this happen?
Always
@svobs svobs mentioned this issue Mar 10, 2023
Merged
2 tasks
@low-batt
Copy link
Contributor

Reproduced for me. As there is no "undo" to recover the history entry if you accidentally pressed the delete key I consider not prompting for a confirmation a high priority defect.

@low-batt low-batt linked a pull request Mar 10, 2023 that will close this issue
Playback History Window: add confirmation before delete from keypress, add DEL key trigger, remove {modifier}+BS triggers #4256
Merged
2 tasks
@uiryuu uiryuu reopened this Mar 25, 2023
@low-batt
Copy link
Contributor

low-batt commented Jan 2, 2024

This is fixed in the released version of IINA.

@low-batt low-batt closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svobs svobs

Labels
bug priority: high progress: fixed/implemented
Projects
None yet
Milestone
No milestone
3 participants
@svobs @uiryuu @low-batt