Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Loop mode cannot be toggled off via menu command after it is turned on #3626

Closed
vassudanagunta opened this issue Jan 27, 2022 · 6 comments
Closed

File Loop mode cannot be toggled off via menu command after it is turned on #3626

vassudanagunta opened this issue Jan 27, 2022 · 6 comments
Labels
progress: fixed/implemented

Comments

@vassudanagunta
Copy link

System and IINA version:

  • macOS 12.1
  • IINA 1.2.0 build 129

Expected behavior:

Selecting the File Loop menu item will toggle File Loop mode between on and off (with a ✔︎ appearing next to the menu item when on, see #3625)

Actual behavior:

File Loop mode does not toggle off. One is forced either to restart IINA or figure out how to create a key binding to do so (very hard!).

Workaround:

Create a key binding with the action: cycle-values loop "no". This reveals another bug: one cannot create a simple toggle keybinding. I have to create a separate cycle-values loop "yes" A cycle-values loop binding does not work as expected.
@low-batt
Copy link
Contributor

Reproduced for me. This is a defect.

IINA code is treating the mpv loop-file property as a boolean flag. It is not a boolean. That is the source of these problems. This is the definition of the property from the mpv manual:

--loop-file=<N|inf|no>, --loop=<N|inf|no>
   Loop a single file N times. inf means forever, no means normal playback.

@CarterLi has a fix for this. He is currently away. I will coordinate with him when he gets back.

@vassudanagunta
Copy link
Author

Thanks! A side note: you guys might want to consider using Issue Labels to mark issues that have been verified, was actually an mpv issue, etc. That way you could get a filtered list of the open 1.2k (‼️) issues.

@low-batt
Copy link
Contributor

I'm an IINA user that noticed the core developers were overloaded and have been helping by investigating problems and posting proposed solutions. I do not have the GitHub privileges required to add labels.

The core developers are currently reviewing and merging proposed fixes as a part of preparing the next release. That may still take a while as there are a lot of fixes outstanding and we do want to be careful and not send out a release with regressions in it.

I will discuss this issue with CarterLi. He just announced he is going to be unavailable for a couple of weeks, so don't expect a quick update. This issue is simple enough that it certainly should be fixed in this coming release in my opinion.

@vassudanagunta
Copy link
Author

Thanks for contributing to FOSS!

This was referenced Apr 24, 2022
Closed
Merged
CarterLi added a commit to CarterLi/iina that referenced this issue Apr 28, 2022
@CarterLi
PlaylistView: Fix loop* issues
559f650 
1. Store preference for playlist loop status
2. Make `loop file` actually work and add a `loop file` button

Fix iina#3625 and iina#3626

TODO: The style of the new `loop file` button in active mode doesn't
match other buttons in playlist view, which needs rework

Related PR: iina#3700
@CarterLi CarterLi mentioned this issue Apr 28, 2022
Merged
2 tasks
CarterLi added a commit to CarterLi/iina that referenced this issue Apr 29, 2022
@CarterLi
PlaylistView: Fix loop* issues
2adeea7 
1. Store preference for playlist loop status
2. Make `loop file` actually work and add a `loop file` button

Fix iina#3625 and iina#3626

TODO: The style of the new `loop file` button in active mode doesn't
match other buttons in playlist view, which needs rework

Related PR: iina#3700
CarterLi added a commit to CarterLi/iina that referenced this issue Apr 30, 2022
@CarterLi
PlaylistView: Make loop file actually work and add a loop file bu…
b79baa8 
…tton

Fix iina#3625 and iina#3626

TODO: The style of the new `loop file` button in active mode doesn't
match other buttons in playlist view, which needs rework

Related PR: iina#3700
@low-batt
Copy link
Contributor

low-batt commented May 9, 2022

Fix has been merged into the develop branch.

@low-batt
Copy link
Contributor

Closing. Fixed in IINA 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
progress: fixed/implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vassudanagunta @low-batt