Skip to content

Not possible to toggle audio filters in menu #3462

Closed
@runeflobakk

Description

System and IINA version:

  • macOS Catalina 10.15.7
  • IINA 1.1.2 (and also all earlier versions I can remember)

Expected behavior:

Clicking menu item Audio -> Saved Audio Filters should enable me to click any of my saved audio filters to toggle them on or off.

Suggestion: clicking an audio filter here should not close the menu but add an indicator of the filter being enabled or not. This will enable adding multiple filters without having to navigate to the menu for each filter.

Actual behavior:

I see my saved audio filters, but each item is "disabled" (grey) and not clickable.

Screenshot:
saved-audio-filters-not-clickable

Steps to reproduce:

  • Add an audio filter, e.g: Custom (FFmpeg) - Filter value: pitch=1.05946, Filter name: rubberband
  • click "Save" button next to the added filter, name it something eg "Pitch +1"
  • disable it by clicking "-"
    • verify the saved filter is not clickable in Audio -> Saved Audio Filters
  • click the checkbox next to the saved filter in the Audio Filters... dialog to enable the filter
    • verify the saved filter now has a ✔ next to it in Audio -> Saved Audio Filters

How often does this happen?

I don't think I have seen the saved filters being clickable in earlier versions either. I always have to open the Audio Filters... window to toggle the saved filters.

Thanks for making IINA! 🏆

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions