Added Dockerfile for the markdownlint-cli #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andmos
force-pushed
the
feature/anm-dockerfile
branch
2 times, most recently
from
41cf3a4 to
ab5ac67
Compare
|
Thank you! I don’t use Docker, so if someone else who does is able to review these changes, that would be great. My one comment would be that there are a lot of lines in the “ignore” file that aren’t relevant. My preference would be to remove them, but if this is a standard template, that seems reasonable. |
|
Ah yeah I copied the |
explicit path added folder to share cleaned up .dockerignore
andmos
force-pushed
the
feature/anm-dockerfile
branch
from
ab5ac67 to
1d3d24f
Compare
|
Hi, I know Docker! The dockerfile looks fine and works, and the .dockerignore file was updated recently to not have too many irrelevant ignore lines, so I would suggest approving this PR. |
|
Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
Found myself in the need for a
Dockerfilefor the project, as I use it as a part of a containerized CI pipeline. Thought I'd share the file with the project if desired 😃