Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wishAll):fixed wishAll & code clean up #13

Merged
merged 1 commit into from
Aug 28, 2018
Merged

fix(wishAll):fixed wishAll & code clean up #13

merged 1 commit into from
Aug 28, 2018

Conversation

igniteram
Copy link
Owner

  • Fixed credentials not getting saved after first login in facebook wish --all
  • Removed all unnecessary page helper functions
  • Removed all unnecessary try/catch blocks
  • Improved error messages to look more clean
  • Some code clean up in birthday.ts file
  • This PR fixes add config login in wish --all option as well! #12

@igniteram
fix(wishAll):Fixed wishAll & code clean up
bf48f34 
* Fixed credentials not getting saved after first login in `facebook wish --all`
* Removed all unnecessary page helper functions
* Removed all unnecessary try/catch blocks
* Improved error messages to look more clean
* Some code clean up in `birthday.ts` file
* This PR fixes #12
@igniteram igniteram merged commit 03a3851 into master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add config login in wish --all option as well!
1 participant
@igniteram