Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Logo component; adding Ant Design #872

Merged
merged 3 commits into from
Mar 28, 2018
Merged

Refactoring Logo component; adding Ant Design #872

merged 3 commits into from
Mar 28, 2018

Conversation

baohouse
Copy link
Contributor

Adding Ant Design that supports React 15.

It's set up to use babel-plugin-import which allows the build to import only the CSS and components from Ant Design that is used, and not the entire Ant Design library.

  • yarn test
  • yarn lint
  • Storybook inspection of Logo which uses antd's grid system
  • Tested use of antd's grid in Chart component and observed it working in if me application
  • Observed that use of antd grid in Chart component only loaded CSS/JS for the grid components, and not the entire antd framework
  • Reverted use of grid on Chart component (since I only needed to test it)

The Logo component was refactored to follow a factory pattern that passes flow and eslint.

@baohouse baohouse requested review from nma and julianguyen March 28, 2018 07:45
@baohouse baohouse merged commit 7503e3d into ifmeorg:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants