Fix node warnings in tests #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request with us! Be sure to follow our Pull Request Practices. Let us know if you have any questions on Slack. |
julianguyen
approved these changes
Apr 7, 2022
|
Thank you for merging this pull request with us! If you haven't already, in another pull request, please add yourself to our About page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I fixed node warnings in HeaderProfile.spec.jsx
More Details
Took a look on tests and decided to mock the entire
Notificationscomponent, warnings were generated sinceaxiosis used in it. Since there are no tests for Notifications in HeaderProfile.spec.jsx I decided to mock the entire component instead of mockingaxios.Corresponding Issue
Closes #2033.
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!