Deploy storybook site to production #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request with us! Be sure to follow our Pull Request Practices. Let us know if you have any questions on Slack. |
paschalidi
changed the title
paschalidi
changed the title
|
@julianguyen this is now ready for review !! 🎉 🎆 Sorry for the huuuuuuge list of commits when you make this tasks with the CI it can get a bit ugly 😥. |
julianguyen
previously approved these changes
Apr 9, 2019
.circleci/config.yml
Outdated
| cd client | ||
| yarn build:storybook | ||
| mv .out .public | ||
| yarn run surge --project .public --domain storybook-ifme.surge.sh |
There was a problem hiding this comment.
Let's rename this to ifme.surge.sh and I can point if-me.org/design to this url!
|
Thank you for merging this pull request with us! If you haven't already, in another pull request, please add yourself to our Contribute page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 👋 hello fellow contributors 🌸
Description
The goal is to have a page with static storybook deployed.
I aborted
storybook-deployeras it was complaining quite a lot for no good reason (one that I could understand at least 😅).We use
surgeinstead to deploy the static storybook website on https://storybook-ifme.surge.shThe logic behind is the same, no static code committed on
master. Storybook is getting build and deployed viasurgeduring the CI time.The new job that has been added on this PR
deploy-storybookwill be triggered only when a PR is merged onmasteras we dont want storybook to be deployed on every PR one makes.Corresponding Issue
Closes #1390
Test Coverage
This PR contains only infrastructural work thus no tests have been written.