Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title text component #463

Merged

Conversation

aaryanpraveen16
Copy link
Contributor

@aaryanpraveen16 aaryanpraveen16 commented Mar 23, 2024

The Pull Request is ready

Overview

Created card component . Card component has 3 props titleText, titleLevel, sideMode: boolean.

Review points

Documentation-Website

  • mobile view is usable
  • desktop view is usable
  • no a-tags are used directly (NavLink, MailLink, ExternalLink instead)
  • all new texts are added to the translation files (at least the english one)
  • tests have been added (if required)
  • shared code has been extracted in a different file

Notes

apraveen16 and others added 3 commits March 23, 2024 11:52
…Created components card and updated an existing html element in index.tsx with the card component. Card component has 3 props titleText, titleLevel, sideMode: boolean. </body> <footer></footer>
…issues card changed back to how it was </body> <footer></footer>
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Idrinth Idrinth merged commit 8ded4b7 into idrinth-api-bench:master Mar 23, 2024
24 checks passed
@Idrinth Idrinth mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create titel+text component
3 participants