New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(website): code highlighting style fix #430

Merged

Idrinth merged 2 commits into master from issue-237-simple-dark-mode-fix

Mar 21, 2024

Member

Idrinth commented Mar 21, 2024 •

edited

Loading

The highlight now works in light and dark mode.
fixes #237

The Pull Request is ready

fixes Code Highlighting doesn't respect dark mode #237
all actions are passing
only fixes a single issue

Overview

Custom styles are provided instead of inline ones, so a switch between light and dark mode is possible.

Website

mobile view is usable
desktop view is usable
no a-tags are used directly (NavLink, MailLink, ExternalLink instead)
all new texts are added to the translation files (at least the english one)
tests have been added (if required)
shared code has been extracted in a different file


          bug(website): code highlighting style fix

The highlight now works in light and dark mode.
fixes #237

Idrinth marked this pull request as ready for review

March 21, 2024 03:01


          style

6f88494

sonarqubecloud bot commented Mar 21, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Idrinth merged commit 733e6dc into master

23 of 25 checks passed

Idrinth deleted the issue-237-simple-dark-mode-fix branch

March 21, 2024 03:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet