Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fallback when page loading fails #254

Merged
merged 3 commits into from
Jan 30, 2024
Merged

add fallback when page loading fails #254

merged 3 commits into from
Jan 30, 2024

Conversation

Idrinth
Copy link
Member

@Idrinth Idrinth commented Jan 30, 2024 •
edited
Loading

The Pull Request is ready

  • all actions are passing
  • only fixes a single issue

Website

  • mobile view is useable
  • desktop view is useable
  • no a-tags are used direktly (NavLink, MailLink, ExternalLink instead)
  • all new texts are added to the translation files (at least the english one)
  • tests have been added (if required)
  • shared code has been extracted in a different file

@Idrinth Idrinth marked this pull request as ready for review January 30, 2024 06:48
@Idrinth Idrinth merged commit 8a343cf into master Jan 30, 2024
13 checks passed
@Idrinth Idrinth deleted the add-fallback-on-failed-page-loading branch January 30, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Idrinth