Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a command line option to only run a specific case id #253

Merged
merged 8 commits into from
Feb 2, 2024

Conversation

madina0801
Copy link
Contributor

Issue #203
I just didn't run lint script and got too many warnings. I still get some though, but at least not as many 😄
I cannot get the filtering part, where and how I should filter main tasks, and changed configuration in "main.ts" file. I'm open to any kind of feedback! Thank you in advance :)

framework/src/build-task-list.ts Outdated Show resolved Hide resolved
framework/bin/run-benchmark.js Show resolved Hide resolved
@Idrinth
Copy link
Member

Idrinth commented Jan 30, 2024

I just didn't run lint script and got too many warnings. I still get some though, but at least not as many 😄

Don't worry too much about it, the linter is set to very strict, so it's rare to not find something

I cannot get the filtering part, where and how I should filter main tasks, and changed configuration in "main.ts" file.

You will have to hand through the id to run from main to executor to the task list builder. In that you can filter by checking task.id against the taskId you provided.

I'm open to any kind of feedback! Thank you in advance :)

Thanks for the effort, this looks very good as a starting point!

@madina0801
Copy link
Contributor Author

Could you please kindly review?^^ And maybe reach out to me on Discord: @madss20 ? Cause it's getting quite long :) have a nice rest of your day!

@Idrinth
Copy link
Member

Idrinth commented Jan 30, 2024

@madina0801 sent you a friend request on discord, username should be obvious :)
I believe I underestimated this task :( I didn't expect it to be this complicated.

@Idrinth Idrinth merged commit 4a47140 into idrinth-api-bench:master Feb 2, 2024
7 checks passed
Idrinth pushed a commit that referenced this pull request Feb 4, 2024
Idrinth pushed a commit that referenced this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants