Fix test compile errors #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamTheCoder
force-pushed
the
fix-test-compile-errors
branch
from
da01cf3 to
ee2b18f
Compare
GrahamTheCoder
force-pushed
the
fix-test-compile-errors
branch
from
d578963 to
dd3315d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main point of this PR is to make it easy to avoid any new non-compiling tests being added. i.e. Make test assertion cover any compilation issues in source or target.
About 20% of the tests have compilation issues of some kind. You could argue in some cases it's beneficial to be able to cope with dodgy input, but most of the tests aren't doing that, so should be fixed at some point. The exception to the rule is the MissingSemanticInfo tests which are explicitly intended to cover incomplete input. I've decided to still make the compilation errors visible in the output since being explicit rarely hurts, and could help debugging.
CS8751: Internal error in the C# compiler.which looks like it might be a due to an invalid array initialization outputThe contextual keyword 'var' may only appear...