added default values and one more argument "max_checkpoints" to --help #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ints to prevent default deleting checkpoints if there are more than 5.
akademi4eg
requested changes
Feb 7, 2017
train.py
Outdated
| @@ -267,7 +270,7 @@ def main(): | |||
| sess.run(init) | |||
|
|
|||
| # Saver for storing checkpoints of the model. | |||
| saver = tf.train.Saver(var_list=tf.trainable_variables()) | |||
| saver = tf.train.Saver(var_list=tf.trainable_variables(), max_to_keep=args.max_checkpoints) # TODO hier ansetzen | |||
There was a problem hiding this comment.
What does this TODO mean?
train.py
Outdated
| @@ -44,13 +45,13 @@ def _str_to_bool(s): | |||
|
|
|||
| parser = argparse.ArgumentParser(description='WaveNet example network') | |||
| parser.add_argument('--batch_size', type=int, default=BATCH_SIZE, | |||
| help='How many wav files to process at once.') | |||
| help='How many wav files to process at once. Default: 1') | |||
There was a problem hiding this comment.
This should be taken from BATCH_SIZE variable.
train.py
Outdated
| parser.add_argument('--data_dir', type=str, default=DATA_DIRECTORY, | ||
| help='The directory containing the VCTK corpus.') | ||
| parser.add_argument('--store_metadata', type=bool, default=False, | ||
| help='Whether to store advanced debugging information ' | ||
| '(execution time, memory consumption) for use with ' | ||
| 'TensorBoard.') | ||
| 'TensorBoard. Default: False') |
There was a problem hiding this comment.
Let's also use a variable with default parameter value here (and other similar places).
…er.add_argument functions. Also removed two TODOs I forgot to delete. Sorry about that.
akademi4eg
approved these changes
Feb 8, 2017
|
What is a use case where having more than few last checkpoints would be useful? |
|
|
@Fjolnir-Dvorak ok, sounds reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added default values to --help and added a new parameter --max_checkpoints to prevent default deleting checkpoints if there are more than 5.