Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug preventing training without conditioning #203

Merged
merged 1 commit into from
Jan 25, 2017

Conversation

devinplatt
Copy link
Contributor

Hey guys, thanks for creating this great repo! I was very excited that I could train a Wavenet model over the weekend :)

I tried to train a network this weekend on a single large audio file, and I had to edit the code to make it work. It turns out that the findall method of Python's regex returns an empty list when there are no matches, instead of None as was assumed here (if None were returned, the "not None" in the new code would still return True).

@devinplatt
Copy link
Contributor Author

Also, this is my first pull request, so let me know if I did anything incorrect. Thanks!

@akademi4eg akademi4eg merged commit 8dd8b74 into ibab:master Jan 25, 2017
@akademi4eg
Copy link
Collaborator

Thanks, @devinplatt !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants