[locale] Breton [br]: Fix lack of meridiem #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eur e brezhoneg Lizherennañ Mat eo g.m. evit PM (goude merenn) ha a.m. evit AM (a-raok merenn). -- Should be g.m. for PM, stand for goude merenn and a.m. for AM stand for a-raok Merenn Here some sources : http://www.brezhoneg.bzh/177-divizou-hag-erbedadennou-ar-chuzul-skiantel.htm https://www.unicode.org/cldr/charts/latest/summary/br.html
Codecov Report
@@ Coverage Diff @@
## dev #856 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 160 160
Lines 1205 1206 +1
Branches 248 249 +1
=========================================
+ Hits 1205 1206 +1
Continue to review full report at Codecov.
|
|
Hi some sources about the apostrophe change. :) |
|
Waiting for native speaker review ( 0 / 2 ) |
iamkun
changed the title
|
I am native and this is correct. |
|
@jbleduigou ? :) |
|
LGTM ! |
|
We could maybe add some tests for this language? |
|
I look for the test yes, but was a bit confused by the logic. It's look like an abstraction of the testing process, I wouldn't broke it. :D |
|
You can create a file like |
|
@o-Chamie-o Hi, there will be a release this week. Do you have some free time to add your test? That could make it into this coming release. 😬 |
iamkun
pushed a commit
that referenced
this pull request
Apr 10, 2020
## [1.8.24](v1.8.23...v1.8.24) (2020-04-10) ### Bug Fixes * Add config option to RelativeTime plugin ([#851](#851)) ([bd24034](bd24034)) * add Duration plugin ([#858](#858)) ([d568273](d568273)) * Add en-in, en-tt locales ([#855](#855)) ([c39fb96](c39fb96)) * add isToday, isTomorrow, isYesterday plugins ([#857](#857)) ([fc08ab6](fc08ab6)) * Add option callback to Calendar plugin ([#839](#839)) ([b25be90](b25be90)) * Fix monthsShort for locale fr ([#862](#862)) ([d2de9a0](d2de9a0)) * Update Breton locale (br) meridiem config ([#856](#856)) ([a2a6672](a2a6672)) * Update Ukrainian (uk) locale relative time ([#842](#842)) ([578bc1a](578bc1a))
|
🎉 This PR is included in version 1.8.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.24](iamkun/dayjs@v1.8.23...v1.8.24) (2020-04-10) ### Bug Fixes * Add config option to RelativeTime plugin ([#851](iamkun/dayjs#851)) ([bd24034](iamkun/dayjs@bd24034)) * add Duration plugin ([#858](iamkun/dayjs#858)) ([d568273](iamkun/dayjs@d568273)) * Add en-in, en-tt locales ([#855](iamkun/dayjs#855)) ([c39fb96](iamkun/dayjs@c39fb96)) * add isToday, isTomorrow, isYesterday plugins ([#857](iamkun/dayjs#857)) ([fc08ab6](iamkun/dayjs@fc08ab6)) * Add option callback to Calendar plugin ([#839](iamkun/dayjs#839)) ([b25be90](iamkun/dayjs@b25be90)) * Fix monthsShort for locale fr ([#862](iamkun/dayjs#862)) ([d2de9a0](iamkun/dayjs@d2de9a0)) * Update Breton locale (br) meridiem config ([#856](iamkun/dayjs#856)) ([a2a6672](iamkun/dayjs@a2a6672)) * Update Ukrainian (uk) locale relative time ([#842](iamkun/dayjs#842)) ([578bc1a](iamkun/dayjs@578bc1a))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.8.24](iamkun/dayjs@v1.8.23...v1.8.24) (2020-04-10) ### Bug Fixes * Add config option to RelativeTime plugin ([#851](iamkun/dayjs#851)) ([bd24034](iamkun/dayjs@bd24034)) * add Duration plugin ([#858](iamkun/dayjs#858)) ([d568273](iamkun/dayjs@d568273)) * Add en-in, en-tt locales ([#855](iamkun/dayjs#855)) ([c39fb96](iamkun/dayjs@c39fb96)) * add isToday, isTomorrow, isYesterday plugins ([#857](iamkun/dayjs#857)) ([fc08ab6](iamkun/dayjs@fc08ab6)) * Add option callback to Calendar plugin ([#839](iamkun/dayjs#839)) ([b25be90](iamkun/dayjs@b25be90)) * Fix monthsShort for locale fr ([#862](iamkun/dayjs#862)) ([d2de9a0](iamkun/dayjs@d2de9a0)) * Update Breton locale (br) meridiem config ([#856](iamkun/dayjs#856)) ([a2a6672](iamkun/dayjs@a2a6672)) * Update Ukrainian (uk) locale relative time ([#842](iamkun/dayjs#842)) ([578bc1a](iamkun/dayjs@578bc1a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eur e brezhoneg Lizherennañ
Mat eo g.m. evit PM (goude merenn) ha a.m. evit AM (a-raok merenn).
--
Should be g.m. for PM, stand for goude merenn and a.m. for AM stand for a-raok Merenn
Here some sources :
http://www.brezhoneg.bzh/177-divizou-hag-erbedadennou-ar-chuzul-skiantel.htm
https://www.unicode.org/cldr/charts/latest/summary/br.html