Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 79 missing locales #541

Merged
merged 1 commit into from Mar 28, 2019
Merged

Add 79 missing locales #541

merged 1 commit into from Mar 28, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 22, 2019

Hi,

I wrote a script and copied all the missing locales from moment.js.

Just the most important parts like month name and week name.

@codecov-io
Copy link

codecov-io commented Mar 22, 2019

Codecov Report

Merging #541 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #541    +/-   ##
====================================
  Coverage   100%   100%            
====================================
  Files        70    149    +79     
  Lines       681    918   +237     
  Branches    119    119            
====================================
+ Hits        681    918   +237
Impacted Files Coverage Δ
src/locale/is.js 100% <100%> (ø)
src/locale/fr-ch.js 100% <100%> (ø)
src/locale/my.js 100% <100%> (ø)
src/locale/bm.js 100% <100%> (ø)
src/locale/jv.js 100% <100%> (ø)
src/locale/x-pseudo.js 100% <100%> (ø)
src/locale/ky.js 100% <100%> (ø)
src/locale/en-il.js 100% <100%> (ø)
src/locale/nl-be.js 100% <100%> (ø)
src/locale/fy.js 100% <100%> (ø)
... and 148 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be6b891...c4ac0be. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #541 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #541    +/-   ##
====================================
  Coverage   100%   100%            
====================================
  Files        70    149    +79     
  Lines       681    918   +237     
  Branches    119    119            
====================================
+ Hits        681    918   +237
Impacted Files Coverage Δ
src/locale/is.js 100% <100%> (ø)
src/locale/fr-ch.js 100% <100%> (ø)
src/locale/my.js 100% <100%> (ø)
src/locale/bm.js 100% <100%> (ø)
src/locale/jv.js 100% <100%> (ø)
src/locale/x-pseudo.js 100% <100%> (ø)
src/locale/ky.js 100% <100%> (ø)
src/locale/en-il.js 100% <100%> (ø)
src/locale/nl-be.js 100% <100%> (ø)
src/locale/fy.js 100% <100%> (ø)
... and 148 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be6b891...c4ac0be. Read the comment docs.

@iamkun iamkun merged commit f75a125 into iamkun:dev Mar 28, 2019
iamkun pushed a commit that referenced this pull request Apr 2, 2019
## [1.8.12](v1.8.11...v1.8.12) (2019-04-02)

### Bug Fixes

* Add .get API ([7318797](7318797))
* Add 79 locales ([#541](#541)) ([f75a125](f75a125))
* Add Calendar plugin ([d1b9cf9](d1b9cf9))
* Add isoWeeksInYear plugin ([2db8631](2db8631))
* Add Occitan (oc-lnc) locale file ([#551](#551)) ([c30b715](c30b715))
* Add plugin minMax to sopport .max .min ([2870a23](2870a23))
* Fix set Month Year error in last day of the month ([d058f4a](d058f4a))
* Update ko locale weekdaysShort  ([#543](#543)) ([317fd3e](317fd3e))
* Update localizedFormat plugin to support lowercase localizable formats (l, ll, lll, llll) ([#546](#546)) ([f2b5ebf](f2b5ebf))
@iamkun
Copy link
Owner

iamkun commented Apr 2, 2019

🎉 This PR is included in version 1.8.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Apr 2, 2019
@mariomc
Copy link
Contributor

mariomc commented Apr 3, 2019

Thanks @xxyuk !
Could you extend (or make available) the script for the localized formats as well? locale.format in dayjs and locale.longDateFormat in moment
Pretty please 😅

name: 'en-au',
weekdays: 'Sunday_Monday_Tuesday_Wednesday_Thursday_Friday_Saturday'.split('_'),
months: 'January_February_March_April_May_June_July_August_September_October_November_December'.split('_'),
weekStart: 1,
Copy link

@sstur sstur Jul 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe this is correct (or else Moment has changed it since you made this PR). According to Moment Australia has a weekStart of 0 (Sunday). I can't find a canonical source to back up either choice, but I wanted to point out that Day.js is deviating from Moment in this case. When tested on MacOS (System Preferences -> Languages & Region -> change Region to Australia) it appears that Australia starts their week on a Sunday.

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.12](iamkun/dayjs@v1.8.11...v1.8.12) (2019-04-02)

### Bug Fixes

* Add .get API ([7318797](iamkun/dayjs@7318797))
* Add 79 locales ([#541](iamkun/dayjs#541)) ([f75a125](iamkun/dayjs@f75a125))
* Add Calendar plugin ([d1b9cf9](iamkun/dayjs@d1b9cf9))
* Add isoWeeksInYear plugin ([2db8631](iamkun/dayjs@2db8631))
* Add Occitan (oc-lnc) locale file ([#551](iamkun/dayjs#551)) ([c30b715](iamkun/dayjs@c30b715))
* Add plugin minMax to sopport .max .min ([2870a23](iamkun/dayjs@2870a23))
* Fix set Month Year error in last day of the month ([d058f4a](iamkun/dayjs@d058f4a))
* Update ko locale weekdaysShort  ([#543](iamkun/dayjs#543)) ([317fd3e](iamkun/dayjs@317fd3e))
* Update localizedFormat plugin to support lowercase localizable formats (l, ll, lll, llll) ([#546](iamkun/dayjs#546)) ([f2b5ebf](iamkun/dayjs@f2b5ebf))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.12](iamkun/dayjs@v1.8.11...v1.8.12) (2019-04-02)

### Bug Fixes

* Add .get API ([7318797](iamkun/dayjs@7318797))
* Add 79 locales ([#541](iamkun/dayjs#541)) ([f75a125](iamkun/dayjs@f75a125))
* Add Calendar plugin ([d1b9cf9](iamkun/dayjs@d1b9cf9))
* Add isoWeeksInYear plugin ([2db8631](iamkun/dayjs@2db8631))
* Add Occitan (oc-lnc) locale file ([#551](iamkun/dayjs#551)) ([c30b715](iamkun/dayjs@c30b715))
* Add plugin minMax to sopport .max .min ([2870a23](iamkun/dayjs@2870a23))
* Fix set Month Year error in last day of the month ([d058f4a](iamkun/dayjs@d058f4a))
* Update ko locale weekdaysShort  ([#543](iamkun/dayjs#543)) ([317fd3e](iamkun/dayjs@317fd3e))
* Update localizedFormat plugin to support lowercase localizable formats (l, ll, lll, llll) ([#546](iamkun/dayjs#546)) ([f2b5ebf](iamkun/dayjs@f2b5ebf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants